[Ffmpeg-devel] [PATCH] xan_dpcm in MPlayer + libavformat

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:

> M?ns Rullg?rd wrote:
>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>> 
>>> Hi
>>>
>>> M?ns Rullg?rd wrote:
>>>> Diego Biurrun <diego at biurrun.de> writes:
>>>>
>>>>> Attached patch is necessary to make xan_dpcm work in MPlayer with the
>>>>> libavformat AVI demuxer.  Since it just adds another line to an already
>>>>> present hack I hope it's acceptable...
>>>>>
>>>>> Diego
>>>>>
>>>>> Index: libavformat/avidec.c
>>>>> ===================================================================
>>>>> --- libavformat/avidec.c	(revision 7117)
>>>>> +++ libavformat/avidec.c	(working copy)
>>>>> @@ -451,8 +451,10 @@
>>>>>                          st->need_parsing = 0;
>>>>>                      /* force parsing as several audio frames can be in
>>>>>                         one packet */
>>>>> -                    if (xan_video)
>>>>> +                    if (xan_video){
>>>>>                          st->codec->codec_id = CODEC_ID_XAN_DPCM;
>>>>> +                        st->codec->codec_tag = 0;
>>>>> +                    }
>>>>>                      break;
>>>>>                  default:
>>>>>                      st->codec->codec_type = CODEC_TYPE_DATA;
>>>> The proper fix would of course be for mplayer to use codec_id instead
>>>> of codec_tag to choose decoder.  Well, it's ugly enough as it is, so I
>>>> don't object to adding this to the hack.  That said, I'd be grateful
>>>> to whomever could find the person responsible for this lunacy in the
>>>> first place, and shoot him.
>>> Agree. I wont object either.
>> 
>> You won't object to the shooting?  Or did you mean the hack?
>
> Both.

You mean "neither" ;-)

-- 
M?ns Rullg?rd
mru at inprovide.com