[Ffmpeg-devel] [PATCH] xan_dpcm in MPlayer + libavformat

[Diego Biurrun]

On Sat, Nov 18, 2006 at 03:34:08PM +0100, Michael Niedermayer wrote:
> 
> On Sat, Nov 18, 2006 at 01:58:54PM +0100, Diego Biurrun wrote:
> > On Sat, Nov 18, 2006 at 03:20:24AM +0100, Michael Niedermayer wrote:
> > > 
> > > On Fri, Nov 17, 2006 at 05:17:58PM -0800, Mike Melanson wrote:
> > > > 
> > > > Right. The people (Origin) that developed this format never applied with 
> > > > Microsoft for a specific codec ID; they didn't mean for these files to 
> > > > be played in general media players. They have codec ID 0x0001 (usually 
> > > > reserved for PCM). There is data elsewhere in the AVI file indicating 
> > > > 'Axan'. All written up here:
> > > 
> > > AVCodecContext.stream_codec_tag i assume, and i would appreciate it if
> > > someone would remove this dirty "if video is xan then audio is so too"
> > > hack and instead add Axan to riff.c and check both stream_codec_id and
> > > codec_id
> > 
> > Dunno if I understood you correctly (probably not), but here is a patch
> > that contains the hack a bit more based on your suggestion to check
> > stream_codec_tag.  It's better than it was before at least.
> 
> yes, its better, apply it

Applied with a slightly better comment.

I'll have to note here that it was a xine developer that introduced this
hack and an MPlayer developer that fixed it.  Our reputation for hacks
is entirely undeserved ;-p

> > BTW, some of the comments in that file seem misplaced.  Maybe someone
> 
> yes

So who can correct them? :-)

Diego