[Ffmpeg-devel] GET/PUT_UTF8 misleading/wrong comment
Reimar Döffinger
Reimar.Doeffinger
Sun Nov 19 10:45:54 CET 2006
Hello,
On Sat, Nov 18, 2006 at 03:45:37PM +0100, Michael Niedermayer wrote:
> On Sat, Nov 18, 2006 at 12:13:30PM +0100, Reimar D?ffinger wrote:
> > The comments say about the GET_BYTE/PUT_BYTE parameters:
> > "It will be execuded up to 4 times."
> > or
> > "PUT_BYTE will be executed up to 4 times".
> > While this may be right with valid UTF8, there is nothing at all in the
> > code to ensure this.
> > How should this be fixed?
> > Either replace 4 by 7, and maybe add that for valid UTF8 it will be 4 at
>
> yes
>
> utf8 is (mis)used by flac so limiting to 4 could be problematic
I extended the comment to say that the limit is 4 for valid utf-8 but up
to 7 in the general case.
Feel free to complain/improve if it is not good.
Greetings,
Reimar D?ffinger
More information about the ffmpeg-devel
mailing list