[Ffmpeg-devel] [PATCH] DV Tune Up

[Michael Niedermayer]

Hi

On Tue, Nov 14, 2006 at 05:12:01PM -0600, Brian Brice wrote:
> Hello.
> 
> I have a patch by a coworker of mine that tunes up some issues with DV
> encoding and outputting.  These issues came up when trying to send DV
> data to a DV camera.  The major issue is regarding audio not being able
> to play while the DV data was being sent.  Other issues are for writing
> "correct" info in certain packs according to standards.  Thanks!

ping roman ...

[...] 
> dvenc.c:
> line 129-
> buf[3]- the speed for NTSC should be "0xa0" signalling that it is an IEC
> stream. But this is specific to us, because cameras like incoming
> streams to be this way.
> 
> All the following changes are suggested to match SMPTE 314m.
> 
> line 204-
> The Timecode packs should be written only for SSYB IDs- 3,4,5 and 9,10,11.
> 
> dvdata.h:
> line 2707-
> For SSYB number 11 ID0 has APT2,1,0=001 (314m)
> 
> dv.c:
> line 1099-
> apt should be 0 for NTSC and PAL DV
> line 1167-
> The existing code was writing SSYB numbers 0-5 in DIF blocks 2 & 3. I
> changed it to write SSYB numbers 0-5 in DIF block 2 and 6-11 in DIF
> block 3.

this should be ideally split into independant patches (but its romans 
decission if he insists on that or applies/rejects it as it is) and 
regression test checksums might need updating

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is