[Ffmpeg-devel] [PATCH] put_mpeg4_qpel16_h_lowpass altivec, take 2

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sun, Nov 26, 2006 at 05:23:35PM +0100, Luca Barbato wrote:
>> Brian Foley wrote:
>> > --- ppc/dsputil_ppc.c	(revision 7166)
>> > +++ ppc/dsputil_ppc.c	(working copy)
>> > @@ -274,7 +275,12 @@
>> >      }
>> >  
>> >  #ifdef HAVE_ALTIVEC
>> > -    if(ENABLE_H264_DECODER) dsputil_h264_init_ppc(c, avctx);
>> > +#ifdef ENABLE_H264_DECODER
>> > +    dsputil_h264_init_ppc(c, avctx);
>> > +#endif
>> 
>> cosmetic....
>
> Yes, also please use the style of the file, so the following should be
>
>> > +#ifdef ENABLE_MPEG4_DECODER
>> > +    dsputil_mpeg4_init_altivec(c, avctx);
>> > +#endif
>
> if (ENABLE_MPEG4_DECODER) dsputil_mpeg4_init_altivec(c, avctx);

Note that ENABLE_FOO_DECODER is *always* defined.  It will be either 0
or 1.  For #ifdefs CONFIG_FOO_DECODER is the proper symbol to test.

-- 
M?ns Rullg?rd
mru at inprovide.com