[Ffmpeg-devel] [PATCH] move ready_floor1 to vorbis.h , change some sruct internals in vorbis.c

[Michael Niedermayer]

Hi

On Sun, Oct 01, 2006 at 11:38:35AM +0200, Oded Shimon wrote:
> first step to make functions common between vorbis.c and vorbis_enc.c .
> 
> OK to commit?
> 
> BTW, the floor calculation in vorbis.c is inlined (render_line) right in 
> the floor decode function, so it would be somewhat harder for me to split 
> that out...
> 
> All of the common functions I am putting in vorbis.h . They are mostly 
> small, biggest of them is this one, maybe the codebook len2vlc . So I 
> don't think they deserve a seperate file...

i have no objections to putting speed critical functions as static inline
in vorbis.h but functions which are used just during init should be shared
at both source and object level

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is