[Ffmpeg-devel] [PATCH] Which Vorbis encoder by default

[Diego Biurrun]

On Mon, Oct 02, 2006 at 09:46:02PM +0200, Oded Shimon wrote:
> On Mon, Oct 02, 2006 at 08:37:14PM +0200, Michael Niedermayer wrote:
> > 
> > On Mon, Oct 02, 2006 at 07:20:30PM +0200, Diego Biurrun wrote:
> > > On Mon, Oct 02, 2006 at 05:13:08PM +0200, Oded Shimon wrote:
> > > > On Mon, Oct 02, 2006 at 04:53:23PM +0200, Oded Shimon wrote:
> > > > > Right now, the only way to get ffmpeg to use the library vorbis encoder is 
> > > > > to manually disable the native one.
> > > > > I'm thinking maybe the default vorbis encoder should be the library one, 
> > > > > and the way to choose the native one would be with -acodec vorbis_native . 
> > > > > You'd still need to use --enable-libogg --enable-vorbis to get the library 
> > > > > one, just like before... But if you didn't, there would be no "vorbis" 
> > > > > encoder at all, just "vorbis_native".
> > > > 
> > > > Different patch - there will always be a "vorbis" encoder, which one it is 
> > > > depends on if ffmpeg was compiled with --enable-vorbis or not (which is 
> > > > now a misleading option name btw, it should be --enable-libvorbis), and 
> > > > there will always be a "vorbis_native" encoder. Is this acceptable?
> > > 
> > > I dislike adding native to the name of our encoder.  I'd say rename the
> > > libvorbis one to libvorbis or oggvorbis instead.
> > 
> > agree
> 
> Well the intent is to use the libvorbis encoder by default if ffmpeg was 
> compiled with it...

That's perfectly OK, but independent of adding native to the name of our
encoder .. :)

Diego