[Ffmpeg-devel] H.264 encoder

[Panagiotis Issaris]

Hi,

On Thu, Oct 05, 2006 at 05:53:16PM +0300, Uoti Urpala wrote:
> On Thu, 2006-10-05 at 16:43 +0200, Panagiotis Issaris wrote:
> > On Thu, Oct 05, 2006 at 05:34:26PM +0300, Uoti Urpala wrote:
> > > On Thu, 2006-10-05 at 15:35 +0200, Panagiotis Issaris wrote:
> > > > +            int16_t val = levels[i];
> > > 
> > > > +                val -= (val>>31)|1;
> > > 
> > > Seems you didn't spot the bug in Michael's recommendation :)
> > And I still don't :) I just rechecked and it seems to be working...
> 
> Actually it should work that way too (so it's not really a bug), but I
> think it would be better to use (val>>15) with a 16-bit variable.
Ouch! I didn't even see that! :-D And it was _right_ in front of me... I was
even wondering why you didn't add more context to the codeblock! :-D 

Thanks for noticing!

With friendly regards,
Takis