[Ffmpeg-devel] [BUG] in make uninstall-headers

[Víctor Paesa]

Hi,

>On Wed, Oct 04, 2006 at 11:46:05AM +0200, V?ctor Paesa wrote:
>> >
>> > Victor Paesa said:
>> >>
>> >> make uninstall produces this error:
>> >>
>> >> make -C libavutil   uninstall-headers
>> >> make[1]: Entering directory
>> >> `/home/wzrlpy/src/FFmpeg-20061002-6412/ffmpeg/libavutil'
>> >> rm -f "/usr/local/include/ffmpeg/avutil.h
>> >> /usr/local/include/ffmpeg/common.h
>> >> /usr/local/include/ffmpeg/mathematics.h
>> >> /usr/local/include/ffmpeg/integer.h
/usr/local/include/ffmpeg/rational.h
>> >> /usr/local/include/ffmpeg/intfloat_readwrite.h
>> >> /usr/local/include/ffmpeg/md5.h /usr/local/include/ffmpeg/adler32.h
>> >> /usr/local/include/ffmpeg/log.h /usr/local/include/ffmpeg/fifo.h"
>> >> rm: cannot remove `/usr/local/include/ffmpeg/avutil.h
>> >> /usr/local/include/ffmpeg/common.h
>> >> /usr/local/include/ffmpeg/mathematics.h
>> >> /usr/local/include/ffmpeg/integer.h
/usr/local/include/ffmpeg/rational.h
>> >> /usr/local/include/ffmpeg/intfloat_readwrite.h
>> >> /usr/local/include/ffmpeg/md5.h /usr/local/include/ffmpeg/adler32.h
>> >> /usr/local/include/ffmpeg/log.h /usr/local/include/ffmpeg/fifo.h': File
>> >> name too long
>> >>
>> >> This proposed patch (also attached) should solve it.
>> >>
>> >> --- ffmpeg/common.mak   (revision 6412)
>> >> +++ ffmpeg/common.mak   (working copy)
>> >> @@ -86,7 +86,7 @@
>> >>         -rm -f "$(libdir)/$(LIB)"
>> >>
>> >>  uninstall-headers:
>> >> -       rm -f "$(addprefix $(incdir)/,$(HEADERS))"
>> >> +       rm -f $(addprefix $(incdir)/,$(HEADERS))
>> >>         rm -f "$(libdir)/pkgconfig/lib$(NAME).pc"
>> >
>> > That fix is incorrect, as it leaves the names unquoted.
>>
>> Right, it would fail on paths with spaces inside.
>>
>> Next attempt:
>
>Thanks, applied.

Thanks for the commit, but I believe the commit log message should
be more in the line of:

"Quote names individually, otherwise the whole list of files
was being undertood by shell as a single long filename."

Regards,
V?ctor Paesa