[Ffmpeg-devel] H.264 encoder

[Michael Niedermayer]

Hi

On Wed, Oct 11, 2006 at 06:00:23PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On Tue, Oct 10, 2006 at 09:36:20PM +0200, Michael Niedermayer wrote:
> > > > [...]
> > > pred_non_zero_count() is using non_zero_count_cache, which is getting filled by
> > > fill_caches() which is dependent on MpegEncContext. This makes it nearly
> > > impossible to reuse this unless I pull in MpegEncContext in the H264 encoder.
> > > Would that be a good idea?
> > 
> > probably not -> change pred_non_zero_count() so it takes the top and left
> > values as arguments instead of H264Context, or change it so a it takes a
> > pointer to non_zero_count_cache ...
> 
> Something like the attached patch does? Or should I drop the const and move left
> and top to the outer scope?

id move them out as the resulting code is simpler ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is