[Ffmpeg-devel] Re: [PATCH] Tiertex .SEQ files support

[Gregory Montoir]

Hi

Baptiste Coudurier wrote:
> Hi
> 
> [...]
>>
>> patch looks ok
>>
> 
> While testing it, I experienced SIGSEGV:
> 
> ffmpeg -i Gameover.seq test.mpg
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1480051008 (LWP 24653)]
> 0x083c54a7 in seqvideo_decode_frame (avctx=0x8667180, data=0xafc43f04,
> data_size=0xafc44090, buf=0x86eadd0 "\003",
>     buf_size=8210) at tiertexseqv.c:131
> 131             dst[offset] = *src++;
> 
> (gdb) bt
> #0  0x083c54a7 in seqvideo_decode_frame (avctx=0x8667180,
> data=0xafc43f04, data_size=0xafc44090, buf=0x86eadd0 "\003",
>     buf_size=8210) at tiertexseqv.c:131
> #1  0x080c1f80 in avcodec_decode_video (avctx=0x8667180,
> picture=0xafc43f04, got_picture_ptr=0xafc44090, buf=0x86eadd0 "\003",
>     buf_size=8210) at utils.c:899
> #2  0x080643ef in output_packet (ist=0x8674c60, ist_index=0,
> ost_table=0x8674d30, nb_ostreams=2, pkt=0xafc44748)
>     at ffmpeg.c:1101
> #3  0x08066343 in main (argc=Cannot access memory at address 0x0
> ) at ffmpeg.c:1940
> 
> Gergory, could please see what's going wrong ? Thanks a lot.

Apparently, some of the data files are filled with 0's at the end.
So, the previous code was allocating packets with no data, hence the
segfault while decoding.

I fixed this in the attached patch. While I was at it, I also updated
the copyright headers in the video decoder and demuxer files.

Regards,
Gregory
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg-tiertexseq-20061011.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061011/89664c52/attachment.txt>