[Ffmpeg-devel] Re: [PATCH] Tiertex .SEQ files support

[Gregory Montoir]

Hi

Baptiste Coudurier wrote:
> Hi
> 
> Gregory Montoir wrote:
>>> [...]
>>>
>>> Gergory, could please see what's going wrong ? Thanks a lot.
>> Apparently, some of the data files are filled with 0's at the end.
>> So, the previous code was allocating packets with no data, hence the
>> segfault while decoding.
>>
>> I fixed this in the attached patch. While I was at it, I also updated
>> the copyright headers in the video decoder and demuxer files.
>>
> 
> I tried your latest patch and still get SIGSEGV:
> 
> FFmpeg version SVN-r6668, Copyright (c) 2000-2006 Fabrice Bellard, et al.
>   configuration:  --cc=distcc gcc-4.1 --tune=pentium4 --enable-gpl
> --enable-faac --enable-dts --enable-a52 --enable-x264 --enable-faad
> --enable-mp3lame --enable-static --enable-pthreads --enable-pp
> --enable-amr_nb --enable-amr_wb
>   libavutil version: 49.0.1
>   libavcodec version: 51.18.0
>   libavformat version: 50.5.0
>   built on Oct 12 2006 11:27:15, gcc: 4.1.2 20061007 (prerelease)
> (Debian 4.1.1-16)
> Input #0, tiertexseq, from 'Gameover.seq':
>   Duration: 00:00:24.8, start: 0.000000, bitrate: 352 kb/s
>   Stream #0.0: Video: tiertexseqvideo, pal8, 256x128, 25.00 fps(r)
>   Stream #0.1: Audio: pcm_s16be, 22050 Hz, mono, 352 kb/s
> File 'test.mpg' already exists. Overwrite ? [y/N] y
> Output #0, mpeg, to 'test.mpg':
>   Stream #0.0: Video: mpeg1video, yuv420p, 256x128, q=2-31, 200 kb/s,
> 25.00 fps(c)
>   Stream #0.1: Audio: mp2, 22050 Hz, mono, 64 kb/s
> Stream mapping:
>   Stream #0.0 -> #0.0
>   Stream #0.1 -> #0.1
> Press [q] to stop encoding
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1479719232 (LWP 5595)]
> 0x083e5e5b in seqvideo_decode_frame (avctx=0x8667180, data=0xafd5b024,
> data_size=0xafd5b1b0, buf=0x86eadc0 "\003",
>     buf_size=8210) at tiertexseqv.c:131
> 131             dst[offset] = *src++;
> 
> 
> Same line.

Seems to work fine here and valgrind doesn't complain either.

Some ideas :
- did you apply this bitstream patch [1] before testing this ?
- maybe the file got altered during the transfer ? the md5 of the
   gameover.seq file should be 552ef9dc10ae13fc2c04e08765091079
- does the crash also occurs with the other file (intro.seq) ?

Gregory

[1]http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-September/045596.html