[Ffmpeg-devel] Re: x264-r592 breaks ffmpeg r6687

[sean]

Ramiro Polla wrote:
> Hello,
> 
> sean wrote:
>> Today's x264 svn breaks today's ffmpeg:
>>
>> gcc   -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
>> -D_ISOC9X_SOURCE -I/usr/src/redhat/BUILD/ffmpeg 
>> -I/usr/src/redhat/BUILD/ffmpeg 
>> -I/usr/src/redhat/BUILD/ffmpeg/libavutil -fPIC -march=k8 -pthread -g 
>> -Wdeclaration-after-statement -Wall -Wno-switch 
>> -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Winline -O3 
>> -fPIC -DPIC -c -o x264.o x264.c
>> x264.c: In function 'X264_init':
>> x264.c:149: error: 'struct <anonymous>' has no member named 
>> 'i_rf_constant'
>> make[1]: *** [x264.o] Error 1
>>
> Attached is a one-letter patch...
> 
> Ramiro Polla
> 
> 
> ------------------------------------------------------------------------
> 
> Index: libavcodec/x264.c
> ===================================================================
> --- libavcodec/x264.c	(revision 6687)
> +++ libavcodec/x264.c	(working copy)
> @@ -146,7 +146,7 @@
>      else{
>          if(avctx->crf){
>              x4->params.rc.i_rc_method = X264_RC_CRF;
> -            x4->params.rc.i_rf_constant = avctx->crf;
> +            x4->params.rc.f_rf_constant = avctx->crf;
>          }else if(avctx->cqp > -1){
>              x4->params.rc.i_rc_method = X264_RC_CQP;
>              x4->params.rc.i_qp_constant = avctx->cqp;
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Thanks.

  I sure wish x264 would make some announcement.

sean