[Ffmpeg-devel] SIGN Macro

[Colin Ward]

Diego Biurrun wrote:
> On Wed, Oct 11, 2006 at 06:15:17PM +0800, Colin Ward wrote:
>>   What are the generally accepted rules and conventions regarding macros in
>> public code?  I just performed an svn update and there is now a SIGN macro
>> defined in libavutil/common.h.  ie.
>>
>>   #define SIGN(a) ((a) > 0 ? 1 : -1)
>>
>>   This clashes with a macro defined in the system headers of my OS so I get
>> lots of warnings.  For FFMPEG macros, weren't people usually prefixing them
>> with FF_ or something similar, to avoid clashes such as this one?
> 
> Fixed.

   Thanks!

-- 
/-------------------------------------------------------------------\
[Hitman/Code HQ - 6502/z80/68000/604e/80x86/ARM coder - Amiga rulez!]
[VZ-200/VIC-20/MZ-700/c16/c64*10/c128*8/Plus-4/CPC464/CD32/500*2    ]
[600/1000/1200*2/A4000/SNES/N64/Dreamcast/Athlon 1100/AmigaOne      ]
[Assembly Language: The most fun you can have with your clothes on! ]
\-------------------------------------------------------------------/