[Ffmpeg-devel] TIFF LZW decoder (was: [PATCH] change gif demuxer to gif decoder)

[Michael Niedermayer]

Hi

On Tue, Oct 24, 2006 at 12:51:02PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Tue, Oct 24, 2006 at 12:24:15PM +0300, Kostya wrote:
> > On Tue, Oct 24, 2006 at 07:35:01AM +0300, Kostya wrote:
> > > 
> > > As I understand, it may not need the wrapper, just two additional fields in
> > > structure: GetCode() pointer and dict_limit (when dictionary size reaches it,
> > > it should be expanded). I also tend to pass buffer and size to the structure
> > > instead of using bytestream.
> > > 
> > > I intend to present this scheme to the end of week.
> >  
> > Here it is. 
> 
> i think that the LZWState struct should not be in the "public"
> header for lzw, but rather in either lzw.c (or lzw_internal.h)
> a "typedef void LZWState;" in lzw.h should be enough ...
> 
> 
> [...]
> > Index: libavcodec/gifdec.c
> > ===================================================================
> > --- libavcodec/gifdec.c	(revision 6781)
> > +++ libavcodec/gifdec.c	(working copy)
> [...]
> > -    /* LZW compatible decoder */
> > -    uint8_t *bytestream;
> [...]
> > -    uint8_t buf[256];
> > +
> > +    uint8_t *bytestream;
> 
> cosmetic move of bytestream
> 
> except these and the indention typo found by aurel, iam fine with the patch

also dont forget to svn cp gifdec.c lzw.c !

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is