[Ffmpeg-devel] RTP patches & RFC

[Michael Niedermayer]

Hi

On Wed, Oct 25, 2006 at 09:02:10PM -0500, Ryan Martell wrote:
> 
> On Oct 25, 2006, at 7:56 PM, Michael Niedermayer wrote:
> 
> >>>
> >>>but note, i wont reject this because of the {} placement if you
> >>>disslike
> >>>it (fixing it myself would just need ~5min or so ...)
> >>
> >>Hope this is a winner; I really want to get the rest of this stuff  
> >>in...
> >
> >could you document the fields of RTPDynamicProtocolHandler?
> >and rename the following, unless i missunderstood their intent, but  
> >their
> >current names really confused me :)
> >protocol_new_extradata_proc()    -> open()
> >protocol_free_extradata_proc()   -> close()
> >protocol_handle_sdp_a_line_proc()-> parse_sdp_a_line()
> >dynamic_protocol_data            -> dynamic_protocol_context
> >protocol_handle_packet_proc      -> parse() or parse_packet() or  
> >even handle_packet()
> >dynamic_packet_handler()         -> parse_dynamic_packet()
> 
> Done.
[...]
> >also a  int priv_data_size; could be added to  
> >RTPDynamicProtocolHandler
> >similar to the other stuff in lav* so that the context alloc/free  
> >can be
> >done outside/without open/close
> 
> No, because I have pointers to pointers in there; it's not just a  
> flat allocated block.

the codecs and (de)muxers have too, but this is insignificant just
leave it as it is


> 
> So, barring the above two, here's the newest patch.  (I really want  
> to get this in, so I can get working on the h264 stuff.  I'm still  
> having an audio sync issue, and I've also found a bug in the rtp/aac  
> stuff (mono doesn't work) that i've fixed...)

[...]
> +        if(s->st && s->dynamic_packet_handler) {
> +            return s->dynamic_packet_handler(s, pkt, 0, NULL, 0);
[...]
> +    RTPDynamicProtocolHandler *dynamic_handler; ///< Only valid if it's a dynamic protocol. (This is the handler structure)
> +    void *dynamic_protocol_data; ///< Only valid if it's a dynamic protocol. (This is any private data associated with the dynamic protocol)
[...]

> +                rtsp_st->dynamic_handler= handler;
> +                if(handler->protocol_new_extradata_proc) {
> +                    rtsp_st->dynamic_protocol_data= handler->protocol_new_extradata_proc();
> +                }
[...]

these amongth other havnt been renamed while the ones in the struct have
been so i think this wont compile ...

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is