[Ffmpeg-devel] [PATCH] BMP encoder

[Michel Bardiaux]

Diego Biurrun wrote:
> On Mon, Oct 30, 2006 at 04:05:39PM +0100, Michel Bardiaux wrote:
>> Currently, only straight RGB.
>>
>> --- libavcodec/bmp.c	(revision 6838)
>> +++ libavcodec/bmp.c	(working copy)
>> @@ -32,10 +34,15 @@
>>  
>> +// Hence the uncondfitional byteswap.
> 
> typo

Right.

> 
>> --- libavcodec/amr.c	(revision 6838)
>> +++ libavcodec/amr.c	(working copy)
>> @@ -57,6 +57,8 @@
>>  
>>  #include "avcodec.h"
>>  
>> +#if defined(CONFIG_AMR_NB) || defined(CONFIG_AMR_NB_FIXED)
>> +
>>  #ifdef CONFIG_AMR_NB_FIXED
>>  
>>  #define MMS_IO
>> @@ -494,8 +496,6 @@
>>  
>>  #endif
>>  
>> -#if defined(CONFIG_AMR_NB) || defined(CONFIG_AMR_NB_FIXED)
>> -
>>  AVCodec amr_nb_decoder =
>>  {
>>      "amr_nb",
> 
> unrelated hunk

Right.

> 
>> --- libavcodec/allcodecs.c	(revision 6838)
>> +++ libavcodec/allcodecs.c	(working copy)
>> @@ -134,6 +134,7 @@
>>  #ifdef CONFIG_PNG_ENCODER
>>      register_avcodec(&png_encoder);
>>  #endif //CONFIG_PNG_ENCODER
>> +    register_avcodec(&bmp_encoder);
>>  #endif
>>  #ifdef CONFIG_PPM_ENCODER
>>      register_avcodec(&ppm_encoder);
> 
> This should be surrounded by proper #ifdef.  Also, put this next to the
> BMP decoder.

Done.

> 
> Diego


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bmpenc.pat
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061030/94ee72f2/attachment.txt>