[Ffmpeg-devel] overall license review - adding proper license headers

[Diego Biurrun]

On Fri, Sep 01, 2006 at 08:02:56PM +0200, Michael Niedermayer wrote:
> 
> On Fri, Sep 01, 2006 at 07:22:25PM +0200, Diego Biurrun wrote:
> > On Fri, Sep 01, 2006 at 07:06:35PM +0200, Michael Niedermayer wrote:
> > > 
> > > On Fri, Sep 01, 2006 at 04:13:47PM +0200, Diego Biurrun wrote:
> > > > I took the time to look through all of the files in FFmpeg and review
> > > > the licensing conditions.  Not the most exciting thing in the world to
> > > > do, but I figured it would be worth the while.  I've stumbled across
> > > > some things that demand attention and/or clarification.  I'm willing to
> > > > commit the fixes, but I'll need your opinions, comments and permission.
> > > > 
> > > > 
> > > > libavcodec/fdctref.c claims all rights reserved.  This is non-free.
> > > > Houston, we have a problem.  Where does this file come from?
> > > 
> > > some reference code, mpeg1 or 2 probably, and as already known its not
> > > part of libavcodec just dct-test so dont compile dct-test if you dont
> > > have an explicit written and with blood signed license from the author
> > 
> > The problem is that we are redistributing a file that does not come with
> > a license that allows redistribution ...
> 
> its only a tiny part of the reference code and its only used for testing and
> comparing our (i)dcts against it furthermore it is as said not part of compiled
> ffmpeg libavcodec or libavformat IMO thats fair use, but iam not against it
> if someone wants to rewrite it, its very little work, just a schoolbook (i)dct

I disagree, there is no way around the "all rights reserved".  We cannot
distribute it in tarballs.

Any volunteers to rewrite it?  Is dct-test still useful?

> > > > libavutil/adler32.c says
> > > > 
> > > >  * For conditions of distribution and use, see copyright notice in zlib.h
> > > > 
> > > > we don't include zlib.h so the conditions should be pasted there IMO.
> > > 
> > > agree
> > 
> > Which zlib.h was it?  The standard one included with zlib and found on
> > most systems?
> 
> i dont know, IIRC i didnt commit that stuff to cvs

Fabrice committed it, the version is very similar to zlib 1.1.3/1.1.4
which are from before the commit.  Notice updated.

Diego