[Ffmpeg-devel] version.sh

[Michel Bardiaux]

Diego Biurrun wrote:
> On Tue, Aug 29, 2006 at 02:53:45PM +0200, Michel Bardiaux wrote:
>> It works only when svn is installed. It means ffmpeg is considered 
>> SVN-rUNKNOWN on all my systems except debian sarge. This is particularly 
>> annoying since the existence of a global version number is one of the 
>> most interesting features of svn vs. cvs.
> 
> Hmm, yes, this is a drawback of the current version.sh.
> 
>> Proposal: if svn is not available (or always?) use the first 
>> committed-rev line in .svn/entries at the top. This is something of a 
>> hack since it assumes the global rev is first, but it could be made more 
>> secure by checking there is a name="" 1 line below and kind="dir" 5 
>> lines below and a matching revision="6125" 8 lines below.
> 
> If this is used as a fallback then it's OK with me.

Agreed.

> 
> Look through the history of MPlayer's version.sh script, we used a
> similar approach before switching to 'svn info'.
> 
> http://svn.mplayerhq.hu/mplayer/trunk/version.sh?view=log

Better not, I dont want to bring mplayer (GPL) code in ffmpeg (LGPL).

> 
> Diego

HaND,
-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/