[Ffmpeg-devel] [PATCH] Linking error when DV disabled

[Panagiotis Issaris]

Hi,

Op maandag 4 september 2006 19:23, schreef M?ns Rullg?rd:
> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
> 
> >> @@ -923,7 +931,9 @@ static int avi_read_seek(AVFormatContext
> >>      }
> >>  
> >>      if (avi->dv_demux)
> >> +#ifdef CONFIG_DV_MUXER
> >>          dv_flush_audio_packets(avi->dv_demux);
> >> +#endif
> >>      /* do the seek */
> >>      url_fseek(&s->pb, pos, SEEK_SET);
> >>      avi->stream_index= -1;
> >> 
> >
> > Same. [#ifdef around if()]
> 
> This one is particularly important, since the if() has no braces,
> meaning that when CONFIG_DV_MUXER isn't defined, the if() applies to
> the next line.  Not what you want.
Ouch! Painful... I should have seen this. Thanks for reviewing and notifying.

With friendly regards,
Takis