[Ffmpeg-devel] [PATCH] Enhance genre, year and track tag support

[Michael Niedermayer]

Hi

On Wed, Sep 06, 2006 at 10:33:33PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On wo, 2006-09-06 at 22:01 +0200, Michael Niedermayer wrote:
> > [...]
> > > This patch enchances the tag support by enabling setting the year, track and genre
> > > tag using FFmpeg.
> > 
> > looks ok, except that it should use AVOption (same for the other stuff of course
> 
> Not really sure I understand this. Do you mean "same for the other
> stuff" as in: all the others, like "title" and "author" should also be
> moved to libavformat/utils.c?

yes


> Is AVOption the successor of OptionDef?

yes and no ...


> And so, should a lot of those be moved to libav(format|codec)/utils.c?

yes, because that way other projects could use them without needing to 
duplicate the per option code in ffmpeg.c

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is