[Ffmpeg-devel] [PATCH] Enhance genre, year and track tag support

[Michael Niedermayer]

Hi

On Thu, Sep 07, 2006 at 01:57:13PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> Op woensdag 6 september 2006 23:56, schreef Michael Niedermayer:
> > [...]
> > > > looks ok, except that it should use AVOption (same for the other stuff of course
> > > 
> > > Not really sure I understand this. Do you mean "same for the other
> > > stuff" as in: all the others, like "title" and "author" should also be
> > > moved to libavformat/utils.c?
> > 
> > yes
> > 
> > 
> > > Is AVOption the successor of OptionDef?
> > 
> > yes and no ...
> Do all these options have to be defined both in the OptionDef array _and_ in the AVOption 
> array of either libavformat or libavcodec (according to its usage)?

of course not


> 
> In trying to understand the usage of AVOption I noticed some definitions related to AVOption,
> which are apparently nowhere used at all: AVOPTION_CODEC_BOOL, ... defined in libavutil/internal.h.
> 
> Can they be removed? If so, I just send a patch.

yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is