[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Fri, Sep 08, 2006 at 05:12:11PM +0200, V?ctor Paesa wrote:
>> > On Tue, Aug 22, 2006 at 12:38:18PM +0200, V?ctor Paesa wrote:
>> >>
>> >> So I give up, the patch attached disables vhook for static Cygwin builds
>> >> (and enables it for shared builds).
>> >
>> > This patch does not apply anymore, thus it's rejected.
>> 
>> Now adapted to SVN-6193
>
> Note: I'm still not entirely happy about static builds failing, thus I'm
> not sure if the patch will ever be applied.
>
> Nevertheless, here are some comments...
>
>> --- ffmpeg-old/configure	2006-09-01 17:44:56.000000000 +0200
>> +++ ffmpeg/configure	2006-09-08 10:35:20.956116400 +0200
>> @@ -602,7 +602,11 @@
>> -vhook="no"
>> +VHOOKSHFLAGS="-shared"
>> +VHOOKLIBS='-Wl,--no-whole-archive \
>> +           -L../libavformat -lavformat$(BUILDSUF) \
>> +           -L../libavcodec  -lavcodec$(BUILDSUF)  \
>> +           -L../libavutil   -lavutil$(BUILDSUF) $(EXTRALIBS)'
>>  extralibs=""
>
> The -Wl part and the -L flags can be added to VHOOKSHFLAGS, thus leaving
> only the libs themselves in VHOOKLIBS.

What is the --no-whole-archive doing there in the first place?  It
only undoes --whole-archive, but we shouldn't be using that flag.

-- 
M?ns Rullg?rd
mru at inprovide.com