[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Víctor Paesa]

Hi,
> On Sat, Sep 09, 2006 at 03:52:09PM +0100, M?ns Rullg?rd wrote:
>> V?ctor Paesa <wzrlpy at arsystel.com> writes:
>> >
>> > As usual, patch attached.
>> >
>> > --- ffmpeg-old/configure	2006-09-01 17:44:56.000000000 +0200
>> > +++ ffmpeg/configure	2006-09-09 15:59:44.890625000 +0200
>> > @@ -602,7 +602,13 @@
>> >  v4l2="no"
>> >  audio_oss="yes"
>> >  dv1394="no"
>> > -vhook="no"
>> > +VHOOKSHFLAGS="-shared \
>> > +              -L../libavformat \
>> > +              -L../libavcodec \
>> > +              -L../libavutil"
>> > +VHOOKLIBS='-lavformat$(BUILDSUF) \
>> > +           -lavcodec$(BUILDSUF) \
>> > +           -lavutil$(BUILDSUF) $(EXTRALIBS)'
>>
>> This includes literal \ characters in the value of VHOOKLIBS.  This is
>> not what you want.
>
> Just put both these values on one long line, like the other platforms.
>
OK

>>  extralibs=""
>>  EXESUF=".exe"
>>  SLIBPREF="cyg"
>> @@ -874,6 +880,14 @@
>>      logfile=/dev/null
>>  fi
>>
>> +# FIXME It should be posible to create vhooks for Cygwin static builds,
>> +# I leave this as a challenge to linker script wizards.
>> +if test "$targetos" = "CYGWIN" ; then
>> +    if test "$lstatic" = "yes" ; then
>> +        vhook="no"
>> +    fi
>> +fi
>
> This should with the rest of the cygwin specific bits.
>
I would need a hint on how to do that, I wrote this chunk after the
configure options are parsed so that $lstatic is set.
Should I parse the --enable/disable-static options?

> BTW, doesn't it apply to mingw too?
>
Most probably, yes, but I haven't tried that. I guess it should be the
subject of another patch.

The customary patch is attached.

Regards,
V?ctor Paesa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.cygwin.vhook.10.patch
Type: application/octet-stream
Size: 1686 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060911/ce9079c1/attachment.obj>