[Ffmpeg-devel] [PATCH] AVOptions description sync

[herve.flores]

Le 11 sept. 06 ? 16:01, Guillaume POIRIER a ?crit :

> Hi,
>
> On 9/11/06, Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>> Hi,
>>
>> The attached patch adds descriptions to the libavcodec AVOptions  
>> array, taken from the
>> OptionDef options[] array.
>>
>>  utils.c |   78 +++++++++++++++++++++++++++++++ 
>> +--------------------------------
>>  1 file changed, 39 insertions(+), 39 deletions(-)
>>
>> A few descriptions had to be altered, such the video bitrate, as  
>> the AVOption parameter
>> wants the value specified to be the actual _bits_ per second,  
>> while the OptionDef parameter
>> takes Kbits/s. To keep this patch from doing more then one thing,  
>> I did not address (or
>> even tried to address) this issue. But at least the patch does not  
>> modify any behavior,
>> except for showing more (and correct) info.
>
> Patch looks good to me, and the information look also correct.
> It also looks simple and uncontroversial
>
> Will apply late this afternoon unless someone disagrees.
>
> Guillaume

sorry to borrow your dev discussion (I'm just an end-user, not dev)
I looked to this patch and I finally understand the syntax of the  
options!

when I type: "ffmpeg -h"
I have
[...]
-strict            <int>   E.V..
-very                      E.V..
-strict                    E.V..
-normal                    E.V..
-inofficial                E.V..
-experimental              E.V..
-b_quant_offset    <float> E.V..
-er                <int>   .DV..
-careful                   .DV..
-compliant                 .DV..
-aggressive                .DV..
-very_aggressive           .DV..
-mpeg_quant        <int>   E.V..
[...]

looking to the code, I understood that some are parameters and some  
are arguments
Perhaps it will be easier to understand if it was:
[...]
-strict            <int>   E.V..
  very                      E.V..
  strict                    E.V..
  normal                    E.V..
  inofficial                E.V..
  experimental              E.V..
-b_quant_offset    <float> E.V..
  er                <int>   .DV..
  careful                   .DV..
  compliant                 .DV..
  aggressive                .DV..
  very_aggressive           .DV..
-mpeg_quant        <int>   E.V..
[...]

then with "-" for parameter and without for argument (or anything  
else to dissociate)

It was just a remark for your others users...
bye

good continuation
great work

Herv?