[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Víctor Paesa]

> On Tue, Sep 12, 2006 at 11:08:51PM +0200, V?ctor Paesa wrote:
>> > On Mon, Sep 11, 2006 at 12:42:21AM +0200, V?ctor Paesa wrote:
>> >> > On Sat, Sep 09, 2006 at 03:52:09PM +0100, M?ns Rullg?rd wrote:
>> >> >> V?ctor Paesa <wzrlpy at arsystel.com> writes:
>> >> >> >
>> >> >> > --- ffmpeg-old/configure	2006-09-01 17:44:56.000000000 +0200
>> >> >> > +++ ffmpeg/configure	2006-09-09 15:59:44.890625000 +0200
>> >> >> @@ -874,6 +880,14 @@
>> >> >>
>> >> >> +if test "$targetos" = "CYGWIN" ; then
>> >> >> +    if test "$lstatic" = "yes" ; then
>> >> >> +        vhook="no"
>> >> >> +    fi
>> >> >> +fi
>> >> >
>> >> > This should with the rest of the cygwin specific bits.
>> >> >
>> >> I would need a hint on how to do that, I wrote this chunk after the
>> >> configure options are parsed so that $lstatic is set.
>> >> Should I parse the --enable/disable-static options?
>> >
>> > Look around line 1360, there are some vhook checks anyway.
>> Integrating
>> > it at this position would be cleaner.
>> >
>> OK, thanks, it makes sense.
>>
>> Patch attached.
>
> Patch applied with a slight simplification and an informative message
> when vhooks get disabled for static builds.
>
> This must have been one of the patches with the highest number of
> revisions.  Your tenacity and willingness to accomodate review after
> review has finally paid off.  Rejoice, it's in :)
>
:-))))