[Ffmpeg-devel] [PATCH] Allowing (k,M,G and B) unit postfixes

[Panagiotis Issaris]

Hi,

Op donderdag 14 september 2006 03:29, schreef Michael Niedermayer:
>[...]
> > Hmm. I think I am currently following the standards as I am using the
> > prefix k, M and G as meaning 1000, 1000000 and 1000000000. For the
> > moment I did not implement any ki, Mi or Gi support as in current FFmpeg
> > the unit for specifying bitrates is in powers of 10 not 2.
> > As in "ffmpeg -i ... -b 800 ..." means a bitrate of 800*1000 bits/s
> > and not 800*1024 bits/s.
> > 
> > I am _not_ following the standards in respect to the fact that I am
> > dropping the specification of the type, meaning the "b" for bits. That
> > was intentional, to make it shorter to type :)
> 
> actually it should be bits/sec for the bitrate if you want to be pedantic
Ah! You're right, I hadn't noticed that.

> > So, with my current patch:
> > "ffmpeg -i ... -b 800000 ..." means 800000 bits/s
> > and is equal in meaning to:
> > "ffmpeg -i ... -b 800k ..." 
> > "ffmpeg -i ... -b 100kB ..." 
> > 
> > Am I correct to think that you like the current behavior, as you dislike
> > the kibi/gibi units? And as in my patch k=/=1024?
> 
> iam not 100% happy with your patch but its ok for the moment, feel free to 
> apply it (ask diego for a svn account if you dont have one yet)
Thanks! I'll apply it.

> one thing i dont like is that B(yte) makes no sense if the fundamental
> unit isnt bits ...
Hmm. Well, I thought the fundamental unit _within FFmpeg_ was bits, that's
why I thought that using B(yte) to differentiate was nice (although not
truly correct, only kB and kb would be).

With friendly regards,
Takis