[Ffmpeg-devel] [PATCH] avctx->frame_size for FAAD

[Andrew Voznytsa]

Guillaume Poirier wrote:
>>  
>> +    avctx->frame_size = 1024; // faad does not support other frame size
>>     
>
> Very well... but shouldn't this be considered as a bug in FAAC that
> should be fixed upstream rather than worked-around here?
>
> ... or is it a feature?
>   

There are a few points:
a) it is better than 0 which was previously there, so it improves
situation at all
b) taking into account that FAAD does not support other frame size it
won't broke 3rd party software which uses FAAD through lavc
c) to get frame size from FAAD its API needs to be modified. Since no
one (AFAIK) is working on FAAD it is better to use this simple & useful
change then trying to modify FAAD