[Ffmpeg-devel] [PATCH] AVOption defaults sync

[Baptiste Coudurier]

Hi

Panagiotis Issaris wrote:
> Hi,
> 
> Op dinsdag 12 september 2006 22:09, schreef Michael Niedermayer:
>> [...]
>>> The attached patch synchronizes the defaults specified in the AVOptions[] array 
>>> to the defaults specified in the ffmpeg.c global static variabels. I took the
>>> ones specified in ffmpeg.c as the new ones for AVOptions, as this preserves the 
>>> current behavior. Regression tests pass.
>> looks ok though i think that we should eventually change the default of 
>> 12frame gop and 200kbit its probably not what most users would want
> Does the "eventually" imply that I can commit the patch as is, and
> that the defaults can be modified in a follow-up patch?
> 
> If so, would 800kbit and 15 frame GOP be more in line with what users
> want? Or should I post to ffmpeg-users and see what is being most
> commonly used? :)
> 

12 is actually much used in MPEG-2 PAL since it's around 25/2 s, 15 is 
more used in NTSC (30/2), DVD specs requires the gop not to be > 18, 
MPEG-4 should use a much larger gop size though.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312