[Ffmpeg-devel] [PATCH] avctx->frame_size/channels/sample_rate fix for AMR

[Michael Niedermayer]

Hi

On Thu, Sep 14, 2006 at 04:31:33PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> >[...]
> >>===================================================================
> >>--- libavcodec/amr.c	(revision 6250)
> >>+++ libavcodec/amr.c	(working copy)
> >>@@ -143,6 +143,11 @@
> >>         av_log(avctx, AV_LOG_ERROR, "Speech_Decode_Frame_init error\n");
> >>         return -1;
> >>     }
> >>+
> >>+    avctx->sample_rate = 8000;
> >>    
> >
> >wont that break amr stored in containers with a sample_rate different from
> >that?
> >  
> AMR NB can only be used with a 8khz sample rate. If the container uses 
> some other value the container is wrong.

so we should drop support for VBR mpeg1 and and mpeg1/2 with non standard
framerates, and h263 with a framerate different from 30000/1001 ?
this will lead to alot of bugreports ...

if we dont drop all these then why amr with non-standard samplerates?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is