[Ffmpeg-devel] [PATCH] Remove "preme" OptionDef option

[Panagiotis Issaris]

Hi,

Op vrijdag 15 september 2006 16:56, schreef Panagiotis Issaris:
> The attached patch removes the "preme" OptionDef option from the ffmpeg.c 
> file. Regression tests succeed.
> 
>  ffmpeg.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 

To make sure these patches are not altering behavior, I've done some
additional tests after the standard regression tests.

I transcoded some sample file to another format, while using the
modified parameter ("preme" in this case). To make sure that the
modified parameter had any influence at all, I checked the md5sum
of the resulting file, while using different values for "preme".
Then I did the same tests with the unpatched executable and
verified that the md5sum for different values was the same as
with the patched executable.

The reason I was doing so was that a simple "grep preme tests/*"
or "grep ibias tests/*" didn't give any results, which made
me assume the impact of using these variables isn't tested.

Should I try to add such tests to the testsuite?

With friendly regards,
Takis