[Ffmpeg-devel] [PATCH] Remove "preme" OptionDef option
Panagiotis Issaris
takis.issaris
Fri Sep 15 20:39:48 CEST 2006
Hi,
On vr, 2006-09-15 at 17:45 +0200, Michael Niedermayer wrote:
>[...]
> patch ok, and i think that as long as you dont change behavior (bit vs. kbit
> for example) you can (if you want) commit these things straight without
> sending a patch
OK. I'll do so for all OptionDef related patch which don't change
behavior and which seem trivial enough to me in their implementation.
>[...]
> > The reason I was doing so was that a simple "grep preme tests/*"
> > or "grep ibias tests/*" didn't give any results, which made
> > me assume the impact of using these variables isn't tested.
> >
> > Should I try to add such tests to the testsuite?
>
> yes, but please add them to existing tests to avoid slowing things down
> unreasonably
I prefer to postpone this, as this will alter the regression tests
results. And I would prefer to be able to see that the regression tests
results are unchanged (obviously unintentional changes too, but I am
hinting at intentional changes here) from before my first AVOption
related patch till the last.
With friendly regards,
Takis
More information about the ffmpeg-devel
mailing list