[Ffmpeg-devel] [PATCH] Split DV demuxer/muxer

[Michael Niedermayer]

Hi

On Fri, Sep 15, 2006 at 09:28:58PM +0200, Diego Biurrun wrote:
> On Fri, Sep 15, 2006 at 08:07:06PM +0200, Panagiotis Issaris wrote:
> > 
> > On vr, 2006-09-15 at 10:52 -0700, Roman Shaposhnik wrote:
> > >[...]
> > > > Attached you'll find two patches containing the results
> > > > of the commands suggested by Michael:
> > > > diff -udp dv.c dvenc.c
> > > > diff -udp dv.c dvdec.c
> > > 
> > >    Looks good. The usual warning about preserving the history applies.
> > My initial patch split the file in a 'dvdec.c' and a 'dvenc.c'. Diego
> > Biurrun prefers 'dv.c' and 'dvenc.c' [1]. What's your favorite pick? :)
> > 
> > Currently there seems to be no "standard" for naming a demuxer/muxer:
> > * avi and flv use the "enc"/"dec" postfixes
> > * asf, gfx, mpegts mov use the "enc" postfix for multiplexers, nothing
> > for demultiplexers
> > * gif does it the other way around: users the "dec" postfix for the
> > demultiplexers, and nothing for the multiplexer :-)
> 
> Now that we can finally rename files I propose unifying this.  Since
> most files whose names don't end in 'enc' are demuxers/decoders I
> propose to keep the name without suffix for decoders/demuxers and use
> and 'enc' suffix for encoders/muxers.
> 
> Opinions?  Otherwise I'm tempted to go ahead with this after the
> weekend.

iam against it
if there is one file it should be format.c if there is a independant muxer
then it should be formatenc.c if there is a independant demuxer it should be
formatdec.c if a file contains code for both muxing and demuxing then it
should be named format.c or formatcommon.c, thats just my humble oppinion
and if any maintainers like to use a different naming sheme for their files
then iam perfectly fine with that

and iam against a mass rename, if at all then this should be done
carefully one format at a time

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is