[Ffmpeg-devel] [PATCH] Add kibi, mibi and gibi support

Panagiotis Issaris takis.issaris
Sat Sep 16 11:21:45 CEST 2006


Hi,

On za, 2006-09-16 at 10:13 +0200, Panagiotis Issaris wrote:
> On za, 2006-09-16 at 09:56 +0200, Panagiotis Issaris wrote:
>[...]
> > The attached patch adds support for the "ki", "Mi" and "Gi" postfixes to
> > the AVOption option parsing code. I do know that this in fact is
> > incorrect, as the official SI standard uses "Ki" instead of "ki" "for
> > consistency reasons" [1]. 
> > 
> > I was wondering how to solve this? Should I just make the kilo case
> > insensitive thus allow both 'k' and 'K' for both? Or make all of them
> > case insensitive? What about 'B' then? I had the initial intention to
> > have 'B' stand for "byte" and 'b' for "bit" with "" being a shorthand
> > for 'b'. If case sensitivity would be removed, both "b" and "B" would
> > stand for "byte" (in the current implementation).
Regression tests succeed with this new corrected version of the same
patch.

 opt.c |   21 ++++++++++++++-------
 1 files changed, 14 insertions(+), 7 deletions(-)

With friendly regards,
Takis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060916T111649-ffmpeg-binary_powers-v2.diff
Type: text/x-patch
Size: 1267 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060916/ceebe943/attachment.bin>



More information about the ffmpeg-devel mailing list