[Ffmpeg-devel] [PATCH] Delphine Software .CIN files support

[Michael Niedermayer]

Hi

On Sun, Sep 17, 2006 at 02:33:19PM +0200, Gregory Montoir wrote:
> 
> Attached patch adds support for Delphine Software .cin files demuxer /
> audio and video decoding. This file format was used in the DOS version
> of the game Fade To Black [1].
> 
> Again, if there's interest, I can upload samples files.
> 
> Regards,
> Gregory
> 
> [1] http://www.mobygames.com/game/fade-to-black
> 

> Index: ffmpeg/libavcodec/delphinecinav.c
> ===================================================================
> --- ffmpeg/libavcodec/delphinecinav.c    (revision 0)
> +++ ffmpeg/libavcodec/delphinecinav.c    (revision 0)
[...]
> +
> +#include "common.h"
> +#include "avcodec.h"
> +
> +#define CIN_CUR_BMP  0  /* current */
> +#define CIN_PRE_BMP  1  /* previous */
> +#define CIN_INT_BMP  2  /* intermediate */

this should be an enum if possible

* furthermore please check that no writes to unallocated memory can happen
* use the bitstream reader if it simplifies the code
* use get_le*() instead of get_buffer() + LE_*() unless the code
  is speed critical or its otherwise needed or cleaner to use LE_*()
* set the timebases correctly (if theres no real timebase/timestamps then
  1/framerate and 1/samplerate are the correct values)

ill do a real review when you ve fixed these


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is