[Ffmpeg-devel] [PATCH] make postproc use avutil features (cleanup part 1 of many)

[Michael Niedermayer]

Hi

On Fri, Sep 22, 2006 at 08:44:17PM +0200, Luca Barbato wrote:
> Luca Barbato wrote:
> [some spaces there]
> 
> disregard the previous one.
> 
> lu
> 
> 
> -- 
> 
> Luca Barbato
> 
> Gentoo/linux Gentoo/PPC
> http://dev.gentoo.org/~lu_zero
> 

> Index: libpostproc/postprocess.c
> ===================================================================
> --- libpostproc/postprocess.c	(revision 6322)
> +++ libpostproc/postprocess.c	(working copy)
[...]
> -                lut= (uint64_t*)memalign(8, 256*8);
> +                lut= (uint64_t*)av_malloc(256*8);

useless cast


[...]
>  void pp_free_mode(pp_mode_t *mode){
> -    if(mode) free(mode);
> +    if(mode) av_free(mode);

useless if()


>  }
>  
>  static void reallocAlign(void **p, int alignment, int size){
> -        if(*p) free(*p);
> -        *p= memalign(alignment, size);
> +        if(*p) av_free(*p);
> +        *p= av_malloc(size);
>          memset(*p, 0, size);

useless if()
memset() -> av_mallocz()

[...]
> -        uint64_t __attribute__((aligned(8))) packedYOffset;
> -        uint64_t __attribute__((aligned(8))) packedYScale;
> +        DECLARE_ALIGNED(16, uint64_t, packedYOffset);
> +        DECLARE_ALIGNED(16, uint64_t, packedYScale);

8 -> 16 why?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is