[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Michael Niedermayer]

Hi

On Sun, Sep 24, 2006 at 02:15:19PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On zo, 2006-09-24 at 13:55 +0200, Panagiotis Issaris wrote:
> > On zo, 2006-09-24 at 13:50 +0200, Panagiotis Issaris wrote:
> > > > [...]
> > > > where it is used now. Furthermore, one parser log message has been
> > > > decreased in severness as it kept complaining about missing '(' in
> > > > "bitexact", "fastint", etc. which are all parsed by eval now, and aren't
> > > > errors. [...]
> > I kept this one out of the previous patch, and am posting it separately,
> > attached to this mail.
> Please ignore the previous patch. It contained nonsense.
> 
> Two updated patches attached. The first one decreases the log level, but
> still results in the log messages being output all the time. The
> alternative version, decreases the log level even more, so that the
> messages are not being output by default.

somehow i think that solving this by changeing the log level is not perfect
but then iam not sure how else to solve it ...
maybe simply returning the error message in an parameter to ff_eval() would
be en option?

maybe something like

ff_eval2(..., char **error);
#if LIBAVCODEC_VERSION < ...
attribute_deprecated ff_eval(eq, ...){
    char *error=NULL;
    double ret=ff_eval2(eq, ..., &error);
    if(error) av_log(..., error, eq);
    return ret;
}
#endif

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is