[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

[Michael Niedermayer]

Hi

On Sun, Sep 24, 2006 at 01:12:49PM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On zo, 2006-09-24 at 13:02 +0200, Michael Niedermayer wrote:
> > > The attached patch handles failure in the ratecontroller in case ff_eval
> > > failed. It does so, by reverting to the default rc_eq in case an invalid
> > > one is specified. Regression tests succeed.
> > 
> > rejected, if the user sets invalid parameters then simply doing something
> > "random" is not ok the user might end up wasting many hours encoding just to
> > realize that ffmpeg "silently" ignored his parameter which had a typo in it
> Hm. Okay, but that was why I used log level AV_LOG_ERROR.
> 
> Furthermore, exiting seems not an option either, does it? As it is a
> library, it would mean any using function would not be able to handle
> the failing behavior as it wants to, but will just exit...
> 
> I'd think propagating the error would be the best thing to do, so the
> calling application can handle the error as it pleases. Would a patch
> propagating the NAN upwards be okay?

yes (or -1 or something like that)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is