[Ffmpeg-devel] [PATCH] make postproc use avutil features (cleanup part 1 of many)

[Michael Niedermayer]

Hi

On Mon, Sep 25, 2006 at 05:36:59PM +0200, Luca Barbato wrote:
> Michael Niedermayer wrote:
> >
> >memset() -> av_mallocz()
> >
> 
> Patch updated
[...]
> @@ -124,8 +126,8 @@
>           */
>          uint64_t *yHistogram;
>  
> -        uint64_t __attribute__((aligned(8))) packedYOffset;
> -        uint64_t __attribute__((aligned(8))) packedYScale;
> +        DECLARE_ALIGNED(16, uint64_t, packedYOffset);
> +        DECLARE_ALIGNED(16, uint64_t, packedYScale);
>  
>          /** Temporal noise reducing buffers */
>          uint8_t *tempBlured[3];
> @@ -137,11 +139,11 @@
>  
>          uint8_t *deintTemp;
>  
> -        uint64_t __attribute__((aligned(8))) pQPb;
> -        uint64_t __attribute__((aligned(8))) pQPb2;
> +        DECLARE_ALIGNED(16, uint64_t, pQPb);
> +        DECLARE_ALIGNED(16, uint64_t, pQPb2);
>  
> -        uint64_t __attribute__((aligned(8))) mmxDcOffset[64];
> -        uint64_t __attribute__((aligned(8))) mmxDcThreshold[64];
> +        DECLARE_ALIGNED(16, uint64_t, mmxDcOffset[64]);
> +        DECLARE_ALIGNED(16, uint64_t, mmxDcThreshold[64]);

please leave the alignment as it is


>  
>          QP_STORE_T *stdQPTable;       ///< used to fix MPEG2 style qscale
>          QP_STORE_T *nonBQPTable;
> Index: libpostproc/postprocess.h
> ===================================================================
> --- libpostproc/postprocess.h	(revision 6329)
> +++ libpostproc/postprocess.h	(working copy)
> @@ -25,6 +25,8 @@
>   *     external api for the pp stuff
>   */
>  
> +#include <avutil.h>
> +

why is that needed?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is