[Ffmpeg-devel] ID3v2

[Michael Niedermayer]

Hi

On Mon, Sep 25, 2006 at 06:09:29PM +0200, Andreas ?man wrote:
> Hi
> 
> Michael Niedermayer wrote:
> >Hi
> >
> >On Sun, Sep 24, 2006 at 01:21:40PM +0200, Andreas ?man wrote:
> >>Hi
> >>
> >>I've written a tentative patch that adds ID3v2.[234] reading
> >>and ID3v2.4 writing to the mp3 (de)muxer. I've tested it
> >>together with xmms and itunes.
> 
> [... snip input code...]
> 
> >
> >IMHO strings in ffmpeg should either be ASCII or UTF-8 but never something
> >random like ISO-8859-1
> >
> 
> [... snip output code ...]
> 
> >
> >UTF8 should be default
> >
> 
> I definitely agree on this. But it rises some more questions which
> is a bit outside the scope of the id3v2-patch itself.
> 
> The asf-parser just cuts away the top 8 bits from the 16-bit (UTF-16?)
> encoded strings. (Which currently works quite well together
> with the ISO-8859-1 encoding). And i bet there are more places
> where some more or less random string-conversion happens.
> 
> So the iconv_() functions come in handy. But i dunno if it's
> is acceptable that ffmpeg depends on iconv?
> 
> Perhaps adding a CONFIG_ICONV is the right way to go, and unless
> it's defined we stick to the current "random" string conversion.
> 
> Should ffmpeg then use UTF-8 (or plain ASCII when compiled without
> iconv -support) internally?

for what would we need iconv? for iso8859-1 -> utf8 we just need a 
128 entry table to convert the high 128 chars

utf16->utf8 / utf8->utf16 also doesnt seem like it would need an external lib

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is