[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

[Panagiotis Issaris]

Hi,

Op dinsdag 26 september 2006 14:52, schreef Michael Niedermayer:
> On Tue, Sep 26, 2006 at 02:40:40PM +0200, Panagiotis Issaris wrote:
> [...]
> > How about a file containing defines like these?
> > #define AV_ERR_BUFSIZE_TOO_SMALL -256
> > #define AV_ERR_DIMENSION_INVALID -257
> > ...
> 
> no objections
I would say such a file belongs in libavcodec/ as people using libavcodec should
be able to have this file installed/available. Would libavcodec/errno.h be okay,
or should we avoid using that name, as it might cause confusion because of the
other errno.h files?

> [...]
> > -        encode_picture(s, s->picture_number);
> > +        if (encode_picture(s, s->picture_number) < 0)
> > +                return -1;
> 
> indention looks odd

>[...]
> > +static int estimate_qp(MpegEncContext *s, int dry_run){
> > +    if (!s->fixed_qscale) {
> > +        s->current_picture.quality;
> 
> hmm "expression;" ...
Ouch. Sorry about those, they were both remains of tracing/debugging code...
Fixed in the attached patch.

 ffmpeg.c                 |    4 ++++
 libavcodec/mpegvideo.c   |   20 +++++++++++++-------
 libavcodec/ratecontrol.c |    6 ++++++
 libavcodec/snow.c        |   12 ++++++++++--
 4 files changed, 33 insertions(+), 9 deletions(-)

Reran regression tests, and they succeeded.

With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060926T150528-ffmpeg-handle_eval_failure.diff
Type: text/x-diff
Size: 5527 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060926/a2eec639/attachment.diff>