[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Måns Rullgård]

Panagiotis Issaris said:
> Hi,
>
> Op zondag 24 september 2006 14:41, schreef Michael Niedermayer:
>> > [...]
>> >
>> > So, this is an updated version of the older patch, with these checks
>> > removed. Regression tests succeed.
>> >
>> > These all work now:
>> > ffmpeg -i src.avi -b 100k     dst.avi
>> > ffmpeg -i src.avi -b 8*9k     dst.avi
>> > ffmpeg -i src.avi -b default  dst.avi
>> > ffmpeg -i src.avi -b QP2LAMDBA*10k   dst.avi
>> >
>> > The last one is not useful for -b, but will be for the next patches in
>> > my queue (the ones for migrating lmax and others).
>> >
>> > And this fails cleanly (no segfaulting or anything):
>> > ffmpeg -i src.avi -b takis    dst.avi
>> >
>> >  eval.c |   62 +++++++++++++++++++++++++++++++++++++++++++--
>> >  opt.c  |   89
>> +++++++++++++----------------------------------------------------
>> >  2 files changed, 78 insertions(+), 73 deletions(-)
>>
>> looks ok
>
> Is it okay to commit this one? It does cause some extra output...
>
> ../ffmpeg_g -y -flags +bitexact -dct fastint -idct simple -y -qscale 10 -f
> pgmyuv -i vsynth1/%02d.pgm -an -vcodec msmpeg4v2 ./data/a-msmpeg4v2.avi
> FFmpeg version SVN-rUNKNOWN, Copyright (c) 2000-2004 Fabrice Bellard
>   configuration:  --enable-gpl --enable-x264 --enable-pthreads
>   libavutil version: 49.0.1
>   libavcodec version: 51.15.0
>   libavformat version: 50.5.0
>   built on Sep 26 2006 16:07:52, gcc: 4.0.3 (Ubuntu 4.0.3-1ubuntu5)
> Parser: missing ( in "bitexact"
> Parser: missing ( in "fastint"
> Parser: missing ( in "simple"

That looks rather bad.  Are you sure this is working?

-- 
M?ns Rullg?rd
mru at inprovide.com