[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Michael Niedermayer]

Hi

On Wed, Sep 27, 2006 at 12:10:21AM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On di, 2006-09-26 at 23:31 +0200, Panagiotis Issaris wrote:
> >[...]
> > 
> > Follow-up patch attached which makes ratecontrol use ff_eval2.
> > Regression tests succeed.
> > [...]
> 
> Should I have put this (in mpegvideo.h):
>  994 double ff_eval(char *s, double *const_value, const char **const_name,
>  995                double (**func1)(void *, double), const char **func1_name,
>  996                double (**func2)(void *, double, double), char **func2_name,
>  997                void *opaque);
> 
> Within this too?
> #if LIBAVCODEC_VERSION_INT < ((51<<16)+(16<<8)+0)
> ...
> #endif

yes probably
well actually the whole ff_eval doesnt belong into mpegvideo.h ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is