[Ffmpeg-devel] [PATCH] Remove the [mb]lm(in|ax) OptionDef

[Víctor Paesa]

Hi,

> Hi
>
> On Wed, Sep 27, 2006 at 11:38:06PM +0200, Panagiotis Issaris wrote:
>> Hi,
>>
>> The attached patch removes the "mblmax" OptionDef. The equally named
>> AVOption takes over its function. A unit change is involved, but as
>> AVOption parameters are now parsed with ff_eval2(), you can use the
>> QP2LAMBDA constant to ease the change.
>>
>> Regression tests succeed.
>>
>>  ffmpeg.c           |   13 -------------
>>  libavcodec/utils.c |    2 +-
>>  2 files changed, 1 insertion(+), 14 deletions(-)
>
> the [mb]lm(in|ax) change looks ok
>

I would suggest to explain the unit change in the documentation,
something like this:

===================================================================
--- ffmpeg/doc/ffmpeg-doc.texi  (revision 6349)
+++ ffmpeg/doc/ffmpeg-doc.texi  (working copy)
@@ -313,6 +313,21 @@
 @item -qcomp compression
 video quantiser scale compression (VBR)

+ at item -lmin lambda
+minimum video lagrange factor (VBR)
+ at item -lmax lambda
+max video lagrange factor (VBR)
+ at item -mblmin lambda
+minimum macroblock quantiser scale (VBR)
+ at item -mblmax lambda
+maximum macroblock quantiser scale (VBR)
+
+These four options (lmin, lmax, mblmin, mblmax) use 'lambda' units,
+but you may use the QP2LAMBDA constant to easily convert from 'q' units:
+ at example
+ffmpeg -i src.ext -lmax 21*QP2LAMBDA dst.ext
+ at end example
+
 @item -rc_init_cplx complexity
 initial complexity for single pass encoding
 @item -b_qfactor factor


Regards,
V?ctor Paesa

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.doc.mblmax.1.diff
Type: text/x-patch
Size: 842 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060928/e255ace0/attachment.bin>