[Ffmpeg-devel] [PATCH] vorbis.h -> vorbis_data.c

[Oded Shimon]

On Sat, Sep 30, 2006 at 06:30:39PM +0200, Balatoni Denes wrote:
> Hi!
> 
> szombat 30 szeptember 2006 17.16-kor Oded Shimon ezeket a bolcs gondolatokat 
> fogalmazta meg:
> > On Sat, Sep 30, 2006 at 06:09:02PM +0300, Oded Shimon wrote:
> > > It would be silly for me to send this as a patch, because it's an almost
> > > completely unreadable ~260kb patch. These are the changes to be made:
> > >
> > > 1. the attached patch, for Makefile and vorbis.c
> 
> I don't find moving all the struct definitions from vorbis.h to vorbis.c a 
> particularly good idea, actually.
> Why should they not be in a header file, as it's normaly done ?

2 problems I had with the structs being there.
1. since vorbis_enc also includes this header, the struct names might mix 
up together
2. for the typedefs you have to include bitstream.h and dsputil.h , which 
can bring confusion with bitstram.h weirdness :/

Is it really how it's normally done in ffmpeg? I see in most files the 
context is defined in the C file together... It's how it is in my vorbis 
encoder too.

- ods15