[Ffmpeg-devel] Re: [PATCH] Fix compilation when using --disable-opts

[Alexis Ballier]

> It might compile but that's because it ends up disabling the asm.

which asm was disabled when building pic before
http://svn.mplayerhq.hu/ffmpeg?view=rev&revision=8549

that changed from :
#if defined(ARCH_X86) && !(defined(PIC) && defined(__GNUC__))
to :
 #if defined(ARCH_X86) && defined(CONFIG_7REGS) && defined(CONFIG_EBX_AVAILABLE)

which had been disabled there :
http://svn.mplayerhq.hu/ffmpeg?view=rev&revision=7173
or there : http://svn.mplayerhq.hu/ffmpeg?view=rev&revision=6834

note that the previous versions disabled the asm optimisations only
when pic is needed.


> That
> does not mean the problem which prevented it from compiling before was
> lack of free registers.

Agreed on that.


> Btw that comment seems wrong/weird - other systems do not "need"
> textrels any more than Gentoo, they use them because the PIC version is
> slow on x86 (and PIC does cause the same slowdown on Gentoo too, so you
> don't "need" them only if you don't need performance).

rephrase it to "want" if you prefer, that was just a copy paste.
There are reasons for building pic shared libs but I'm probably not
the more skilled person to talk about that nor it is relevant here.


-- 
Alexis Ballier.