[Ffmpeg-devel] Fix missing declaration for Altivec

Stanislav Brabec sbrabec
Mon Apr 2 14:54:26 CEST 2007


Guillaume POIRIER wrote:

> > Fixes:
> > yuv2rgb.c: In function 'yuv2rgb_get_func_ptr':
> > yuv2rgb.c:609: warning: implicit declaration of function 'yuv2rgb_init_altivec'
> > yuv2rgb.c:609: warning: initialization makes pointer from integer without a cast
> > ================================================================================
> > --- libswscale/swscale_internal.h
> > +++ libswscale/swscale_internal.h
> > @@ -167,6 +167,9 @@
> >
> >  SwsFunc yuv2rgb_get_func_ptr (SwsContext *c);
> >  int yuv2rgb_c_init_tables (SwsContext *c, const int inv_table[4], int fullRange, int brightness, int contrast, int saturation);
> > +#ifdef HAVE_ALTIVEC
> > +  SwsFunc yuv2rgb_init_altivec(SwsContext *);
> > +#endif
> 
> Are you sure it needs to be protected by HAVE_ALTIVEC? At first sight,
> it doesn't seem to be necessary.

No, it is not necessary, but seems to be correct.

But because it is an internal header, feel free to remove #ifdef.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec at suse.cz
Lihovarsk? 1060/12                            tel: +420 284 028 966
190 00 Praha 9                                fax: +420 284 028 951
Czech Republic                                http://www.suse.cz/





More information about the ffmpeg-devel mailing list