[Ffmpeg-devel] [PATCH] THP PCM decoder (GSoC Qualification)

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
>> [...]
>>
>>>> Index: libavcodec/allcodecs.c
>>>> ===================================================================
>>>> --- libavcodec/allcodecs.c	(revision 8605)
>>>> +++ libavcodec/allcodecs.c	(working copy)
>>>> @@ -242,6 +242,7 @@
>>>>      REGISTER_ENCDEC (ADPCM_SBPRO_3, adpcm_sbpro_3);
>>>>      REGISTER_ENCDEC (ADPCM_SBPRO_4, adpcm_sbpro_4);
>>>>      REGISTER_ENCDEC (ADPCM_SWF, adpcm_swf);
>>>> +    REGISTER_ENCDEC (ADPCM_THP, adpcm_thp);
>>> ENCDEC ?
>>
>> Baptiste said "use CODEC and dummy return -1 to stay in conformance
>> with others (see IMA_QT)".  I assumed it also applied to allcodecs.c.
>> Should I change this to REGISTER_DECODER?
> 
> yes and flame baptiste ;)
> 

rofl, I only said to use ADPCM_CODEC in adpcm.c :/

> @@ -1368,5 +1422,6 @@
> >  ADPCM_CODEC(CODEC_ID_ADPCM_SBPRO_4, adpcm_sbpro_4);
> >  ADPCM_CODEC(CODEC_ID_ADPCM_SBPRO_3, adpcm_sbpro_3);
> >  ADPCM_CODEC(CODEC_ID_ADPCM_SBPRO_2, adpcm_sbpro_2);
> > +ADPCM_DECODER(CODEC_ID_ADPCM_THP, adpcm_thp);

use CODEC and dummy return -1 to stay in conformance with others
(see IMA_QT)

That's ok, I'll just take care of correctly saying something
understandable next time.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312