[Ffmpeg-devel] thp audio decoder

[Diego Biurrun]

On Wed, Apr 04, 2007 at 09:44:59PM +0400, Kislyakov Maxim wrote:
> Michael Niedermayer wrote:
> > please send a proper single unified diff against svn head of your changes
> > like everyone else!
> > also loose the tabs and trailing whitespace and use 4 space indention
> 
> I fixed this. This is the patch. It seems that it works fine with
> stereo too. But it is difficult to debug it. Sorry for answering
> rarely, i have another project at university at the moment.

Haven't you sent a patch before?  This one has a lot of beginner's
mistakes and is rejected.

> --- libavformat/thp.c    (revision 8587)
> +++ libavformat/thp.c    (working copy)
> @@ -1,6 +1,5 @@
>  /*
>   * THP Demuxer
> - * Copyright (c) 2007 Marco Gerards.
>   *

Have you removed all his code?

> @@ -18,153 +17,233 @@
>   * License along with FFmpeg; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
> -
> -
> + 

cosmetics, plus you're adding trailing whitespace..

> --- libavcodec/adpcm.c    (revision 8186)
> +++ libavcodec/adpcm.c    (working copy)
> @@ -772,6 +782,7 @@
>              out = out + 1 - 28*2;
>          }
>  
> +        

cosmetics + added trailing whitespace

> @@ -844,7 +885,7 @@
>      uint8_t shift_left, shift_right;
>      int count1, count2;
> -
> + 

cosmetics + added trailing whitespace

Diego