[Ffmpeg-devel] THP decoder

[Kislyakov Maxim]

> Hi
Hi

Michael Niedermayer wrote:
> On Sat, Apr 07, 2007 at 12:08:20AM +0400, Kislyakov Maxim wrote:
>> Hi,
>> I tried to make everything according your wishes :)
>> This is another new version of the patch.
>> 
> 
> [...]
>> +#include "avformat.h"
>> +#include "allformats.h"
>> +
>> +typedef struct ThpDemuxerContext  {
>> +    int maxAudioSamples;              /* != 0 if sound is stored in
>> file */
> 
> this comment is not doxygen compatible

fixed

> [...]
>> +static int thp_probe(AVProbeData *p)
>> +{
>> +    if (p->buf_size < 4)
>> +        return 0;
>> +    if ((AV_RL32(&p->buf[0]))== MKTAG('T', 'H', 'P', '\0'))
> 
> &[0] and () is superfluous

fixed

> [...]
>> +    if ((version != 0x100) && (version != 0x110))
> 
> superfluous ()

removed

> [...]
>> +    thpDemux->fps = av_int2flt(get_be32(pb));
>> +    av_set_pts_info(st, 64, 1, thpDemux->fps);
> 
> this is wrong av_set_pts_info() does not accept float fps



> [...]
>> +        } 
> 
> trailing whitespace

removed

> [...]
>> +        m = (buf_size - 80) >> st;
>> +        int cnt = 7;
> 
> breaks gcc 2.95

fixed

New patch. I hope this patch is right